Hi, Just wanted to bump this thread. It'd be good to get another ack on these last set of changes. On 25 Feb 2022, at 14:38, Taylor Blau wrote: > On Fri, Feb 25, 2022 at 07:30:49PM +0000, John Cai via GitGitGadget wrote: >> John Cai (3): >> stash: add tests to ensure reflog --rewrite --updatref behavior >> reflog: libify delete reflog function and helpers >> stash: call reflog_delete() in reflog.c >> >> Makefile | 1 + >> builtin/reflog.c | 455 +---------------------------------------------- >> builtin/stash.c | 18 +- >> object.h | 2 +- >> reflog.c | 432 ++++++++++++++++++++++++++++++++++++++++++++ >> reflog.h | 43 +++++ >> t/t3903-stash.sh | 65 +++++-- >> 7 files changed, 539 insertions(+), 477 deletions(-) >> create mode 100644 reflog.c >> create mode 100644 reflog.h > > Thanks; I glossed over the discussion about tests (since it looks like > you and Ævar already have a good handle on how things are going there). > > The rest of this version of the series (which I looked at more closely) > looks good to me. > > Thanks > Taylor
