Make have the "contrib/scalar/Makefile" be stylistically consistent with the top-level "Makefile" in first declaring "all" to be the default rule, follwed by including other Makefile snippets. This adjusts code added in 0a43fb22026 (scalar: create a rudimentary executable, 2021-12-03), it's a style-only change, in a subsequent commit the "QUIET" boilerplate at the beginning of this file will be retrieved via an include, and having an "all:" between the two set of "include"'s after that change would look odd. As noted in [1] using ".DEFAULT_GOAL = all" is another way to do this in more modern GNU make versions, which we already have a hard dependency on, but let's leave any such change for a future improvement and go with using our established pattern consistently for now. 1. https://lore.kernel.org/git/220226.861qzq7d2r.gmgdl@xxxxxxxxxxxxxxxxxxx/ Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> --- contrib/scalar/Makefile | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/contrib/scalar/Makefile b/contrib/scalar/Makefile index 231b1ee1796..1e9b969f3df 100644 --- a/contrib/scalar/Makefile +++ b/contrib/scalar/Makefile @@ -1,3 +1,10 @@ +# The default target of this Makefile is... +all:: + +include ../../config.mak.uname +-include ../../config.mak.autogen +-include ../../config.mak + QUIET_SUBDIR0 = +$(MAKE) -C # space to separate -C and subdir QUIET_SUBDIR1 = @@ -12,12 +19,6 @@ else endif endif -all: - -include ../../config.mak.uname --include ../../config.mak.autogen --include ../../config.mak - TARGETS = scalar$(X) scalar.o GITLIBS = ../../common-main.o ../../libgit.a ../../xdiff/lib.a -- 2.35.1.1228.g56895c6ee86
