On Mon, Feb 28, 2022 at 01:44:01PM -0500, Derrick Stolee wrote: > On 2/28/2022 11:59 AM, Patrick Steinhardt wrote: > > On Mon, Feb 28, 2022 at 11:23:38AM -0500, Derrick Stolee wrote: > >> On 2/28/2022 10:18 AM, Patrick Steinhardt wrote: > >>> I haven't yet found the time to dig deeper into why this is happening. > >>> While the repository is publicly accessible at [1], unfortunately the > >>> bug seems to be triggered by a commit that's only kept alive by an > >>> internal reference. > >>> > >>> Patrick > >>> > >>> [1]: https://gitlab.com/gitlab-com/www-gitlab-com.git > >> > >> Thanks for including this information. Just to be clear: did you > >> include patch 4 in your tests, or not? Patch 4 includes a fix > >> related to overflow values, so it would be helpful to know if you > >> found a _different_ bug or if it is the same one. > >> > >> Thanks, > >> -Stolee > > > > I initially only applied the first three patches, but after having hit > > the fatal error I also applied the rest of this series to have a look at > > whether it is indeed fixed already by one of your later patches. The > > error remains the same though. > > Thanks for this extra context. Is this a commit-graph that you wrote > with the first three patches and then you get an error when reading it? > > Do you get the same error when deleting that file and rewriting it with > all patches included? > > Thanks, > -Stolee Yes, I do. I've applied all four patches from v2 on top of 715d08a9e5 (The eighth batch, 2022-02-25) and still get the same results: $ find objects/info/commit-graphs/ objects/info/commit-graphs/ objects/info/commit-graphs/graph-607e641165f3e83a82d5b14af4e611bf2a688f35.graph objects/info/commit-graphs/commit-graph-chain objects/info/commit-graphs/graph-5f357c7573c0075d42d82b28e660bc3eac01bfe8.graph objects/info/commit-graphs/graph-e0c12ead1b61c7c30720ae372e8a9f98d95dfb2d.graph objects/info/commit-graphs/graph-c96723b133c2d81106a01ecd7a8773bb2ef6c2e1.graph $ git commit-graph verify fatal: commit-graph requires overflow generation data but has none $ git commit-graph write Finding commits for commit graph among packed objects: 100% (10235119/10235119), done. Expanding reachable commits in commit graph: 2197197, done. Finding extra edges in commit graph: 100% (2197197/2197197), done. fatal: commit-graph requires overflow generation data but has none $ rm -rf objects/info/commit-graphs/ $ git commit-graph write Finding commits for commit graph among packed objects: 100% (10235119/10235119), done. Expanding reachable commits in commit graph: 2197197, done. Finding extra edges in commit graph: 100% (2197197/2197197), done. fatal: commit-graph requires overflow generation data but has none) So even generating them completely anew doesn't seem to generate the overflow generation data. Patrick
Attachment:
signature.asc
Description: PGP signature
