On Mon, Feb 28, 2022 at 11:08 PM Jacob Keller <jacob.keller@xxxxxxxxx> wrote: > > On Mon, Feb 28, 2022 at 6:36 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > > > Jacob Keller <jacob.e.keller@xxxxxxxxx> writes: > > > > > +test_expect_success 'name-rev without commitGraph does not handle non-monotonic timestamps' ' > > > + test_config -C non-monotonic core.commitGraph false && > > > + ( > > > + cd non-monotonic && > > > + > > > + rm -rf .git/info/commit-graph* && > > > + > > > + echo "main~3 undefined" >expect && > > > + git name-rev --tags main~3 >actual && > > > + > > > + test_cmp expect actual > > > + ) > > > +' > > > > I doubt it is wise to "test" that a program does _not_ produce a > > correct output, or even worse, it produces a particular wrong > > output. This test, for example, casts in stone that any future > > optimization that does not depend on the commit-graph is forever > > prohibited. > > > > Just dropping the test would be fine, I would think. > > Stolee mentioned it. We could also convert it to a > "test_expect_failure" with the expected output too... But that makes > it look like something we'll fix I'm happy to drop this test though Thanks, Jake
