Re: [PATCH v2 1/8] fetch-negotiator: add specific noop initializor

[Robert Coup <robert@xxxxxxxxxxx>]

Hi,

On Fri, 25 Feb 2022 at 06:19, Junio C Hamano <gitster@xxxxxxxxx> wrote:
>
> > Add a specific initializor for the noop fetch negotiator. This is
>
> "initializer"?

Thanks. A poor translation effort to American English ;-)

> > +
> > +void fetch_negotiator_init_noop(struct fetch_negotiator *negotiator)
> > +{
> > +     noop_negotiator_init(negotiator);
> > +}
>
> Puzzling.  What makes this better than allowing noop-negotiator-init
> to be called directly?

Is simply for naming/API consistency with the regular method. Happy to
call noop_negotiator_init() if you prefer?

Rob :)