Derrick Stolee <derrickstolee@xxxxxxxxxx> writes: >>> +# The remaining tests check timestamps that flow over >>> +# 32-bits. The graph_git_behavior checks can't take a >>> +# prereq, so just stop here if we are on a 32-bit machine. >>> + >>> +if ! test_have_prereq TIME_IS_64BIT >>> +then >>> + test_done >>> +fi >>> +if ! test_have_prereq TIME_T_IS_64BIT >>> +then >>> + test_done >>> +fi >> >> The above is OK but is there a reason why we cannot do >> >> if A || B >> then >> test_done >> fi >> >> here (I am assuming not, but in case I am missing the reason why it >> has to be separate)? > > Does not need to be separate. I just discovered the two different > prereqs for similar, but not exact, checks. I can swap this to an > or statement. I do not think a single condition with single test_done is necessarily better. I was just curious if there was anything subtle going on. Thanks.
