El 25/9/2007, a las 21:34, Jeff King escribió:
On Tue, Sep 25, 2007 at 09:09:00PM +0200, Andreas Ericsson wrote:
We came to the same conclusion at our workplace. Email works
great, but
it's faster and better to just walk over to your colleague and ask
what
he/she thinks about something.
One of the projects I am working on does things this way, but I
have to
admit that I miss the email code-review process. There are often small
fixups (stylistic, minor nits, "I would have done it this way...",
etc)
that are worth pointing out at the time, but are more painful to go
back
and correct much later.
And documenting those discussions can really help other developers
besides the author and reviewer.
Google has a pretty interesting internal code review system:
<http://video.google.com/videoplay?docid=-8502904076440714866>
Cheers,
Wincent
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
