Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: > On Wed, Feb 23 2022, Junio C Hamano wrote: > >> * ab/commit-plug-leaks (2022-02-16) 2 commits >> - commit: use strbuf_release() instead of UNLEAK() >> - commit: fix "author_ident" leak >> >> Leakfixes in the top-level called-once function. >> >> Expecting a reroll. >> I think UNLEAK->strbuf_release() is a regression. >> source: <cover-0.2-00000000000-20220216T081844Z-avarab@xxxxxxxxx> > > After you noted that in [1] I followed-up in [2] giving reasons for > wanting to keep that UNLEAK->strbuf_release() change. What do you think > about that? Do not count and aim to reduce the number of UNLEAK in builtin/ directory. Re-read [1] until you get it. Thanks.