Re: [PATCH v2] add usage-strings check and amend remaining usage strings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Junio C Hamano <gitster@xxxxxxxxx> wrote:

> I notice that the real-looking name
>
>>> Signed-off-by: Abhradeep Chakraborty <chakrabortyabhradeep79@xxxxxxxxx>
>
> does not match with the in-body "From:" that has less real-looking.
> Please fix the in-body "From:" if this is rerolled so that both
> mention the same "Human Readable Name <email@xxxxxxxxx>".

Okay, fixing it. Unfortunately your review came after sending the third
version[1], so this is not fixed in the newest version. But could you
review the newest version of this patch series so that I can make all the
suggested changes in one go?

> Much better than what was posted, but such a heuristic deserves some
> in-code comment to check why we see the first two.

Okay, will add comments to it.

Thanks :)

[1] https://lore.kernel.org/git/pull.1147.v3.git.1645626455.gitgitgadget@xxxxxxxxx/



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux