On 2/22/2022 6:43 AM, Shubham Mishra wrote: Welcome, Subham! > pipes doesn't care about error codes and ignore them thus we should not use them in tests. > As an easy alternative, I am using a tmp file to write from git command so we can test the exit code. This is the correct way to convert the pipes into something that properly notices Git failures. The only issue I have with your patches is that you should insert a newline after your &&. (I'll include an example on patch 1.) > This is my first contribution that's why I am keeping diff short with an intention to understand the process instead of making impactful change in first attempt. Later, I will send more patches to fix the issue for other files. I think this is a great start! After fixing the formatting that I saw, you should be good to start making more changes in a single series. These patches are a good size. Thanks, -Stolee
