I trivial re-roll of v2: https://lore.kernel.org/git/cover-v3-0.3-00000000000-20220219T103752Z-avarab@xxxxxxxxx/ The only change is removing the 3rd patch, per Junio's feedback. Ævar Arnfjörð Bjarmason (2): git-compat-util.h: clarify GCC v.s. C99-specific in comment C99: remove hardcoded-out !HAVE_VARIADIC_MACROS code Documentation/CodingGuidelines | 3 + banned.h | 5 -- git-compat-util.h | 16 +---- trace.c | 80 +-------------------- trace.h | 128 +++++++++++++++------------------ trace2.c | 39 ---------- trace2.h | 25 ------- usage.c | 15 +--- 8 files changed, 65 insertions(+), 246 deletions(-) Range-diff against v3: 1: 1a15fe4fd74 = 1: 1a15fe4fd74 git-compat-util.h: clarify GCC v.s. C99-specific in comment 2: bd0f969be55 = 2: bd0f969be55 C99: remove hardcoded-out !HAVE_VARIADIC_MACROS code 3: 27ea260bbea < -: ----------- trace.h: remove never-used TRACE_CONTEXT -- 2.35.1.1132.ga1fe46f8690