On Sun, Feb 20, 2022 at 08:43:14PM -0500, John Cai wrote: > > One question that I had which I don't see answered already is what the > > plan is for existing reflog-related functions that live in refs.h. > > Should or will those functions be moved to the new reflog-specific > > header, too? > > Thanks for bringing ths up! Maybe this cleanup can be included in a separate > patch series since this one is mainly about getting rid of the shell-out in > stash.c. What do you think? Yeah; I think that's fine. We don't need to get all reflog-related functions moved into reflog.h in the first series, so I think it's fine to move things as you discover them. I was just wondering whether it was something you planned to do at some point (as part of this series, or a future one). Thanks, Taylor