Hi Ed, On Wed, 9 Feb 2022, Edward Thomson wrote: > Hello from libgit2, where we borrowed your xdiff a few years ago and > have watched as we both hacked on it independently. (For us, mostly it > was around tightening some things up around warnings and signed/unsigned > mismatches.) However, we'd love to share a common xdiff implementation, > and we're happy if git is the home for that. Great! > The next patch adds an indirection point, `git-xdiff.h`, that contains > the git-specific functionality in xdiff. This keeps the core of xdiff > to standard functions. Other xdiff users, like libgit2, can specify > their own compatibility functions in this header file. I like this direction and looked over the patch: ACK! > I hope that this allows us to make progress on a common xdiff; we'd love > to go back to building it without warnings, but we'd like to not do that > in isolation. Yes, let's combine efforts. Thank you for kicking this off, Dscho
