Patrick Steinhardt <ps@xxxxxx> writes:
> @@ -1628,8 +1630,19 @@ static int do_fetch(struct transport *transport,
> struct ref *tags_ref_map = NULL, **tail = &tags_ref_map;
>
> find_non_local_tags(remote_refs, &tags_ref_map, &tail);
> - if (tags_ref_map)
> - backfill_tags(transport, tags_ref_map, &fetch_head, worktrees);
> + if (tags_ref_map) {
> + /*
> + * If backfilling tags succeeds we used to not return
> + * an error code to the user at all. Instead, we
> + * silently swallowed that error and updated the local
> + * state of the repository. We now notify the user of
> + * any such errors, but we continue to make sure that
> + * FETCH_HEAD and the upstream branch are configured as
> + * expected.
> + */
> + if (backfill_tags(transport, tags_ref_map, &fetch_head, worktrees))
> + retcode = 1;
I think s/succeeds/fails/
Having said that, I don't think that we need to describe the past here.
Notifying the user if something has failed is expected and doesn't
require an explanation about how we didn't do that in the past.
Everything up to this patch looks good to me.
