Jonathan Tan <jonathantanmy@xxxxxxxxxx> writes: > Glen Choo <chooglen@xxxxxxxxxx> writes: >> The changed function signatures follow repo_submodule_init()'s argument >> order, i.e. "path" then "treeish_name". Where needed, reorder the >> arguments of functions that already take "path" and "treeish_name" to be >> consistent with this convention. > > This paragraph made me nervous, but looking at the diff, you didn't > actually reorder any arguments. Probably best to delete this paragraph. Oh you're right. I was sure that this paragraph used to be relevant, but I guess not. Thanks for the catch.
