On Wed, Feb 16 2022, Glen Choo wrote:
> + switch (get_fetch_recurse_config(task->sub, spf)) {
> + default:
Unfortunately get_fetch_recurse_config() returns "int", and the enum
fields here defined in submodule.h aren't of a named type, so we can't
get the advantage of a complier check for exhaustive enum member
checking here...
> + case RECURSE_SUBMODULES_DEFAULT:
> + case RECURSE_SUBMODULES_ON_DEMAND:
> + *default_argv = "on-demand";
> + break;
> + case RECURSE_SUBMODULES_ON:
> + *default_argv = "yes";
> + break;
> + case RECURSE_SUBMODULES_OFF:
> + continue;
...in any case there's a lot more of them, so just having this "default"
case seems to make sense...
