Glen Choo <chooglen@xxxxxxxxxx> writes: > +/* > + * Holds relevant information for a changed submodule. Used as the .util > + * member of the changed submodule string_list_item. > + */ > +struct changed_submodule_data { > + /* The submodule commits that have changed in the rev walk. */ > + struct oid_array *new_commits; > +}; Overall this change is straightforward and looks good, except that I think that the struct oid_array can be embedded directly instead of through a pointer.