Hi Edward
On 09/02/2022 01:33, Edward Thomson wrote:
Provide an indirection layer into the git-specific functionality and
utilities in `git-xdiff.h`, prefixing those types and functions with
`xdl_` (and `XDL_` for macros). This allows other projects that use
git's xdiff implementation to keep up-to-date; they can now take all the
files _except_ `git-xdiff.h`, which they have customized for their own
environment.
This seems like a sensible way to make it easier to share a common
xdiff. The patch looks good to me apart from
diff --git a/xdiff/xinclude.h b/xdiff/xinclude.h
index a4285ac0eb..bf66dc0a87 100644
--- a/xdiff/xinclude.h
+++ b/xdiff/xinclude.h
@@ -24,6 +24,7 @@
#define XINCLUDE_H
#include "git-compat-util.h"
I think you want to remove this
Best Wishes
Phillip
