On Sat, Jan 29, 2022 at 10:39 PM Elijah Newren <newren@xxxxxxxxx> wrote:
>
> On Fri, Jan 28, 2022 at 3:08 PM Johannes Schindelin via GitGitGadget
> <gitgitgadget@xxxxxxxxx> wrote:
> >
> > After three GSoC/Outreachy students spent an incredible effort on this, it
> > is finally time to put a neat little bow on it.
> >
> > Johannes Schindelin (11):
> > bisect run: fix the error message
> > bisect--helper: retire the --no-log option
> > bisect--helper: really retire --bisect-next-check
> > bisect--helper: really retire `--bisect-autostart`
> > bisect--helper: align the sub-command order with git-bisect.sh
> > bisect--helper: make `--bisect-state` optional
> > bisect: move even the option parsing to `bisect--helper`
> > bisect--helper: using `--bisect-state` without an argument is a bug
> > Turn `git bisect` into a full built-in.
> > bisect: remove Cogito-related code
> > bisect: no longer try to clean up left-over `.git/head-name` files
> >
> > Makefile | 3 +-
> > bisect.c | 3 -
> > builtin.h | 2 +-
> > builtin/{bisect--helper.c => bisect.c} | 201 ++++++++++---------------
> > git-bisect.sh | 84 -----------
> > git.c | 2 +-
> > t/t6030-bisect-porcelain.sh | 1 -
> > 7 files changed, 84 insertions(+), 212 deletions(-)
> > rename builtin/{bisect--helper.c => bisect.c} (87%)
> > delete mode 100755 git-bisect.sh
>
> I read through the series and couldn't spot any problems.
I re-read the series, taking a closer look. Spotted a few minor
things (and left some comments) but the series looks pretty good to
me. I think Dscho's on vacation, so we'll resume the discussion when
he gets back.
