On Fri, Jan 28, 2022 at 3:30 PM Johannes Schindelin via GitGitGadget
<gitgitgadget@xxxxxxxxx> wrote:
>
> From: Johannes Schindelin <johannes.schindelin@xxxxxx>
>
> The `bisect--helper` command is not expected to be used directly by the
> user. Therefore, it is a bug if it receives no argument to the
> `--bisect-state` command mode, not a user error. Which means that we
> need to call `BUG()` instead of `die()`.
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@xxxxxx>
> ---
> builtin/bisect--helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c
> index 4450305c81c..009c919a989 100644
> --- a/builtin/bisect--helper.c
> +++ b/builtin/bisect--helper.c
> @@ -872,7 +872,7 @@ static enum bisect_error bisect_state(struct bisect_terms *terms, const char **a
> struct oid_array revs = OID_ARRAY_INIT;
>
> if (!argc)
> - return error(_("Please call `--bisect-state` with at least one argument"));
> + BUG("bisect_state() called without argument");
>
> if (bisect_autostart(terms))
> return BISECT_FAILED;
> --
> gitgitgadget
Makes sense.
