On Tue, Feb 8, 2022 at 12:18 AM Elijah Newren <newren@xxxxxxxxx> wrote: > On Mon, Feb 7, 2022 at 9:03 PM Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote: > > On Mon, Feb 7, 2022 at 11:14 PM Elijah Newren <newren@xxxxxxxxx> wrote: > > > Was the empty bullet point meant to cover the new patch 6? > > > > The "Updates in v6" section was botched a bit. If you look closely, > > the remaining bullet points actually ended up in the "Updates in v5" > > section. The complete "Updates in v6" section should have been > > (approximately): > > > > * Updated documentation to use "working tree" over "worktree" and > > "<id>" over "<worktree-name>" > > * Delay some allocations to avoid leaking memory in error conditions. > > * Use "main worktree" over "base worktree" in comments. > > * Removed use of git_configset_get_string_tmp() and added a patch that > > removes its public declaration. > > * Fragile variables are replaced with better ones. > > * Variable names and code style improved. > > * Several test cleanups in patch 5. > > So, you clearly also read the patches in this round. Do they also > look good to you? :-) I have not yet looked at either the patches or the range-diff, and I only scanned my eye quickly over the cover letter, but the empty bullet point made me stop and look a bit more carefully at that part (and only that part) of the cover letter. Not sure yet when I'll have time to carefully read this round.
