On Fri, Feb 4, 2022 at 9:04 PM Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> wrote: > I'm not saying we shouldn't have that, but that in any case a sequence of: > > 1. Add a --format option > 2. Add a --object-only alias for a --format (what my RFC 7/7 does) > 3. Add a custom more optimized --object-only implementation > > Would make the patch progression much easier to read, and we'd consider > the correctness of --object-only (1 and 2) separate from the > optimization question (3). > > But maybe we won't need (3) at all in the end, i.e. is (1 and 2) fast > enough for it not to matter (I think probably "yes", but I don't have a > strong opinion on that). Sorry for the late reply, I had a vacation in the last two weeks (Chinese New Year). I have to say it's a very valuable recommendation and at the same time I recognise that spending more time on organizing commits ahead is important and make small steps(or commits) sufficiently. > Now would be a good time :) > > I was reminded of this because Junio's proposed it for next at > https://lore.kernel.org/git/xmqqr18jnr2t.fsf@gitster.g/ > > I think per the above & other replies of mine (including not matters of > code arrangement opinion, but e.g. the doc formatting bug) we'll need at > least one more re-roll of this. Thanks for sticking with this & working > on this! > > I'll indicate that in a reply to that "What's Cooking" report. Thanks for mentioning that. I will back work on it this week. Thanks.
