"Elijah Newren via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: > diff --git a/repo-settings.c b/repo-settings.c > index 00ca5571a1a..38c10f9977b 100644 > --- a/repo-settings.c > +++ b/repo-settings.c > @@ -85,6 +85,8 @@ void prepare_repo_settings(struct repository *r) > r->settings.fetch_negotiation_algorithm = FETCH_NEGOTIATION_SKIPPING; > else if (!strcasecmp(strval, "noop")) > r->settings.fetch_negotiation_algorithm = FETCH_NEGOTIATION_NOOP; > + else if (!strcasecmp(strval, "default")) > + r->settings.fetch_negotiation_algorithm = FETCH_NEGOTIATION_DEFAULT; > } After this step, this function does: * fetch_negotiation_algorithm set to _DEFAULT * experimental bit flips it to _SKIPPING * config is read and skipping/noop/default overwrites it. which is better than ignoring "default", but it strikes me as unnatural. If it were done like this instead: * fetch_negotiation_algorithm is set to _DEFAULT * config is read and skipping/noop/default overwrites it. * experimental bit flips it to _SKIPPING only when it is still _DEFAULT this bug wouldn't have happened, I suspect. More importantly, those who want to say "I want to keep up with the 'possible future default', which is appropriately chosen by Git for opt-in experimenters" by setting feature.experimental to true, would be able to do so when the flow is reordered like so. Setting fetch.negotiationAlgorithm=default would be the way to do so. Let's read on and see later steps of this series achieves the same. Perhaps they may do the same reordering. Thanks.
