Re: [PATCH v8 0/6] implement branch --recurse-submodules

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Glen Choo <chooglen@xxxxxxxxxx> writes:
> Changes since v7:
> * Reword patch 5's commit message
> * In comments and Documentation/git-branch.txt, clarify how branch
>   --recurse-submodules behaves and rename a parameter to better reflect
>   this behavior
> * In t3207, always assert on error messages when using test_must_fail
> * In t3207, assert on config values using test_cmp_config. This avoids
>   the silent failures discouraged by t/README:671.
> * In patch 6, be more explicit about freeing the stack-allocated
>   variable.

I had minor comments [1] which have been addressed, so:

Reviewed-by: Jonathan Tan <jonathantanmy@xxxxxxxxxx>

I'm OK with 6/6 being included or not being included.



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux