On 1/27/2022 2:20 AM, Elijah Newren wrote: > On Tue, Jan 25, 2022 at 10:42 AM Derrick Stolee via GitGitGadget > <gitgitgadget@xxxxxxxxx> wrote: >> >> This series is now based on v2.35.0 since that contains all of the necessary >> topics. > > Heads up for the maintainer: has a minor textual conflict with > en/present-despite-skipped (this series modifies the end of a > paragraph that the other series modifies the beginning of). Thanks for pointing this out. My next version will not have this conflict, so feel free to resolve the conflict by dropping the changes on this side. >> This patch series includes a fix to the bug reported by Sean Allred [1] and >> diagnosed by Eric Sunshine [2]. >> >> The root cause is that 'git sparse-checkout init' writes to the worktree >> config without checking that core.bare or core.worktree are set in the >> common config file. This series fixes this, but also puts in place some >> helpers to prevent this from happening in the future. > This series has become pretty solid. I had only very minor comments > on the patches. Thanks for working on this. Thank you for your careful review. I'll let it simmer over the weekend before sending a v5 that includes your recommended changes. Thanks, -Stolee
