On 1/25/2022 5:40 PM, Taylor Blau wrote: > Here is a(n even) small(er) reroll of my series which fixes a serious problem > with MIDX bitmaps by which they can become corrupt when permuting their pack > order. > > The only change is to revert back to using finalize_object_file(), since it > behaves consistently with other parts of the code that touch $GIT_DIR/objects. > This is safe to do given the other change described in that patch. The > description has been updated slightly to reflect. > > A minor tweak to the tests is done towards the end of the series. But otherwise > this is unchanged from v3. It's been a while since I've looked at this topic, so I re-read the patches and the discussion on this version. I found the patches to be ready to go and the comments that exist to be interesting style points, but not valuable enough to hold up the series. If you _do_ decide to re-roll, then please add Reviewed-by: Derrick Stolee <dstolee@xxxxxxxxxxxxx> Thanks, -Stolee
