On Tue, Jan 25 2022, Taylor Blau wrote: > +test_expect_failure 'changing the preferred pack does not corrupt bitmaps' ' > + rm -fr repo && > + git init repo && > + test_when_finished "rm -fr repo" && Nit: The initial "rm -fr" isn't needed here, and we should aim to have tests clean up after themselves, not needing to clean up after other tests. This appears to have been copy/pasted from the test you added in 54156af0d66 (t5326: test propagating hashcache values, 2021-09-17), which needlessly used that pattern, the tests you added preceding it follow the "clean up your own mess" pattern.
