Taylor Blau <me@xxxxxxxxxxxx> writes: > In a subsequent commit, we'll use the MIDX's new 'RIDX' chunk as a > source for the reverse index's data. But it will be useful for tests to > be able to determine whether the reverse index was loaded from the > separate .rev file, or from a chunk within the MIDX. As for this patch and all subsequent patches, we (at $DAYJOB) discussed during our Review Club the idea of not supporting .rev files altogether. Firstly, because of this bug, we cannot fully trust .rev files anymore. And even if we decided to trust it (or to trust it after some verification step that I can't think of), that file would only be useful for a short time until a regularly scheduled maintenance step regenerates the bitmaps anyway. That would also simplify the code slightly and eliminate the need to test a variety of cases - so we probably wouldn't need the t/lib-bitmap.sh file introduced in patch 6. I'll hold off on reviewing the rest of the patches for now, since they may substantially change if we decide to stop supporting .rev files.
