On Fri, Jan 14, 2022 at 7:16 AM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > There are a few "oops, what we merged recently is broken" topics > that still are not in 'master', but otherwise what we have should > be pretty much what we'll have in the final one. > > - I am reasonably happy with ab/refs-errno-cleanup (just one patch) > that fixes the incorrect state of the code left by the earlier > parts of the topic that have already been merged during this > cycle. > > - I am also OK with ab/reftable-build-fixes (two patches), one for > general type correctness fix, the other for helping older sub-C99 > compilers. I ran into the c99 test balloon. I get the (expected?) c99 build errors and an uncompress2 build error with RHEL7.9's stock gcc 4.8.5. Are we dropping support for RHEL7.9? Using NO_UNCOMPRESS2=YesPlease and CFLAGS += -std=c99 in config.mak works but I'm not sure if we actually expect users to deal with those details themselves. Sorry for being out of the loop on the plan for older toolchains, but I wasn't sure if we should be expecting a patch that configures the default flags so that things build out of the box again or if this is considered the new status quo and we're okay regressing? $ rpm -q zlib-devel zlib-devel-1.2.7-19.el7_9.x86_64 $ gcc -v ... gcc version 4.8.5 20150623 (Red Hat 4.8.5-44) (GCC) Was part of the intention of the test balloon to get reports of this nature? I checked the commit logs and related discussion but that didn't really clarify things. It seems like that was the intention based on the note of, "any warnings will eventually surface." in the commit message for 5f46385309 (config.mak.dev: specify -std=gnu99 for gcc/clang, 2021-12-08). I'll keep an eye out for any patches that I should test in this area. cheers, -- David
