On 1/11/22 1:45 PM, Taylor Blau wrote:
On Tue, Jan 11, 2022 at 09:17:38AM -0800, Lessley Dennington wrote:
On 1/10/22 2:38 PM, Elijah Newren wrote:
Other than that one nit, patches 1-2 (and the testcases in patch 3) are:
Reviewed-by: Elijah Newren <newren@xxxxxxxxx>
Since I wrote the new __gitcomp() function in patch 3, it might be
nice if we can find another reviewer for it. Especially since I've
only lightly touched the completion code and there might be better
ways of achieving what I wrote there.
I agree - I'll chat with some folks today to try to find the best person
to take a look.
Having another set of eyes on this code never hurts, but looking through
this file's shortlog (especially with `--since=1.year.ago`), I'm not
sure how many active reviewers in this area we still have.
Perhaps the best thing to do would be to grow some new area experts here
instead. If I were in Lessley's shoes, I would "think aloud" to make
sure I agreed with your implementation for the new `__gitcomp()`
function.
If other reviewers happen to be around (perhaps Denton, who I added to
the CC) that doesn't hurt either, but short of that...
Thanks,
Taylor
Thanks for the help here, Taylor! I like this suggestion and will add my
thoughts to Elijah's __gitcomp_directories function.
