On Tue, Jan 11, 2022 at 5:40 PM Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> wrote: > > This trivial set of patches fixes compiler complaints from SunCC on > Solaris that are new in v2.35.0-rc0. Thanks, looks fine in principle. For the switch, maybe the block types should be an enum. Is there tooling that would detect a missing case in that case, so we could drop the abort() ? For the 0xffffffff constant, there is probably a better symbolic constant somewhere. Or could we say (1<<64) -1 without causing overflow? -- Han-Wen Nienhuys - Google Munich I work 80%. Don't expect answers from me on Fridays. -- Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
