On Tue, Jan 11, 2022 at 2:02 AM Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> wrote: > > The original rule was introduced by commit: > > > > https://github.com/git/git/commit/28c23cd4c3902449aff72cb9a4a703220be0d6ac > > Let's refer to commits like this: > > 28c23cd4c39 (strbuf.cocci: suggest strbuf_addbuf() to add one strbuf to an other, 2019-01-25) OK, I will. > That file currently has: > > 18:format F =~ "s"; > 26:format F =~ "s"; > 47:format F =~ "s"; > > If we're fixing these let's fix the other logic errors as well. Thanks for the reminding, they'll be applied in the next patch.