Cc’ing Phillip, as he was the one who made the suggestion to make it hidden
On 10 Jan 2022, at 12:38, Junio C Hamano wrote:
> John Cai <johncai86@xxxxxxxxx> writes:
>
>> Hi Junio,
>>
>> ...
>
> Please trim quotes that are irrelevant for understanding what you
> want to say in your message to save recipient's time to find what
> you wrote.
>
>>> + OPT_BOOL(0, "annotate-stdin", &annotate_stdin, N_("annotate text from stdin")),
>>> OPT_BOOL(0, "undefined", &allow_undefined, N_("allow to print `undefined` names (default)")),
>>
>> I’ve changed this back to a non hidden bool. I believe this should be the last thing needed on this one.
>> Let me know if anything else needs adjustment, thanks!
>
> As I said, my mention of hidden vs non-hidden was not my preferrence
> of non-hidden over hidden, but was soliciting opinions from others,
> so I was a bit surprised to see a reroll to change only that thing
> and nothing else so soon.
>
> But if it is your preference to leave it unhidden for now, that is
> fine as well. I have no strong preference over the matter either
> way.
I think it makes sense in this first iteration to keep it non-hidden for visibility purposes.
Maybe in the next release we can make it hidden before we move it altogether.
>
> I see only Dscho on the CC list, but I have this feeling that he
> wasn't the one who suggested to hide the old option. Whoever it
> was, if we can get an ack from them, that would be nicer.
>
> Thanks for working on this.
