> On 01/07/2022 4:39 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > "Issam Maghni via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: > > > From: "Issam E. Maghni" <issam.e.maghni@xxxxxxxxxxx> > > > > I faced `test: too many arguments` when building using sbase [1] > > Building "git" with sbase? It is curious how a loosely written > sample hook script can cause build failures on a platform with a > more strict userspace. Sorry, I rather meant using git with sbase. I’ve submitted at least a half dozen patches similar to this one. My brain is in auto-mode. > Perhaps... > > The sample update script in the templates directory uses the > `-o` and `-a` binary primaries of the "test" command, which > are marked obsolescent in the recent versions of POSIX. > > ...would be sufficient, as 'sbase' would not be the only source of > the userspace whose 'test' lack the -o/-a primaries. You’re right, this is much cleaner. I force-pushed the changes in https://github.com/git/git/pull/1172. I must admit, I’m not familiar (yet) to submitting patches through mailing lists.
