This patch-set removes the mixing of commands constructed using strings with commands constructed using python lists. The goal being to simplify the code by standardising on the usage of lists throughout the script. It also attempts to make usage of shell execution clearer by changing the code to require the caller to explicitly request execution-in-shell if required. With the script changed over to using lists every, there is also a patch to improve the printing of log messages as command strings rather than as stringified python lists This version of the patch-set adds a missing signoff, and corrects a typo in a commit message. Joel Holdsworth (3): git-p4: don't select shell mode using the type of the command argument git-p4: pass command arguments as lists instead of using shell git-p4: don't print shell commands as python lists git-p4.py | 176 ++++++++++++++++++++++++------------------------------ 1 file changed, 79 insertions(+), 97 deletions(-) -- 2.34.1
