René, Here are a couple of extra patches on top of your series which introduce and use a new grep_and_expr() function. Like the final patch says, this isn't about reducing code duplication, but rather about adding visual consistency with the other `compile_pattern_xyz()` functions. Taylor Blau (2): grep: extract grep_binexp() from grep_or_expr() grep: use grep_and_expr() in compile_pattern_and() grep.c | 22 +++++++++++++++------- 1 file changed, 15 insertions(+), 7 deletions(-) -- 2.34.1.455.gd6eb6fd089
