Hi Elijah, On Fri, 31 Dec 2021, Elijah Newren via GitGitGadget wrote: > From: Elijah Newren <newren@xxxxxxxxx> > > Signed-off-by: Elijah Newren <newren@xxxxxxxxx> > --- > t4126: this test does not pass SANITIZE_LEAK; quit claiming it does > > My builds in several different topics keep running into this, and I'm > sure it's a false positive -- I didn't change anything affecting this > test. I've just been ignoring it and submitting anyway, and I suspect > others are too. So that's what is causing this. Thank you for chasing it down, it has been on my TO-DO list e.g. due to https://github.com/git-for-windows/git/runs/4622790431?check_suite_focus=true#step:5:146 Given that it points to a leak in `cmd_format_patch()` (oh no, we're _LEAKING_ some _MEMORY_ in a built-in, how did that ever happen, we must free it before... *checks notes* ... wait, we're quitting immediately after this function anyway? </sarcasm>) I wonder whether the disruption caused by `linux-leaks` should really be considered worth the benefit. Anyway. Thank you for the patch! Ciao, Dscho
