On Wed, Dec 29, 2021 at 12:39 PM Derrick Stolee <stolee@xxxxxxxxx> wrote: > On 12/29/2021 4:39 AM, Elijah Newren wrote: > > No, it's not even rare, let alone very rare. I'd actually call it > > common. Since 'sparse-checkout disable' does not delete the > > sparse-checkout file, and we've encouraged folks to use the > > sparse-checkout command (or a wrapper thereof) instead of direct > > editing of the sparse-checkout file (and indeed, the sparse-checkout > > command will overwrite the sparse-checkout file which further > > discourages users from feeling they own it), having the file left > > around after disabling is the common case. So, the only question is, > > how often do users disable and re-enable sparse-checkout, and > > potentially only do so in some of their worktrees? At my $DAYJOB, > > that's actually quite common. I got multiple reports quite soon after > > introducing our `sparsify` tool about users doing something like this; > > this is what led me to learn of the extensions.worktreeConfig, and why > > I pointed it out to you on your first submission of > > git-sparse-checkout[1] > > (https://lore.kernel.org/git/CABPp-BFcH5hQqujjmc88L3qGx3QAYZ_chH6PXQXyp13ipfV6hQ@xxxxxxxxxxxxxx/) > > Thank you for these comments and the detailed descriptions of things > from your $DAYJOB. That's helpful context and I'm happy to switch back > to enabling the extension in the sparse-checkout builtin. I might need > to rearrange the code so there is an API in worktree.c instead of just > the subcommand in builtin/worktree.c, but that's pretty minor. I'll > keep Eric's earlier suggestion to have the upgrade be a separate call > from the repo_config_set_worktree_gently(). Thanks.
