On Tue, Dec 28 2021, Jeff Hostetler via GitGitGadget wrote: > From: Jeff Hostetler <jeffhost@xxxxxxxxxxxxx> > > Use "size_t" rather than "int" for the "alloc" and "nr_open_regions" > fields in the "tr2tls_thread_ctx". These are used by ALLOC_GROW(). > > This was discussed in: https://lore.kernel.org/all/YULF3hoaDxA9ENdO@nand.local/ Let's keep commit messages self-contained when possible. It's fine to reference on-list discussion (and I often do), but in this case all that's being referenced just seems to be Taylor saying we might as well change this while we're at it. So I'd think a short sentence saying we generally prefer "size_t" for these these days and we might as well change it here while we're at it would suffice over the ML link. > Signed-off-by: Jeff Hostetler <jeffhost@xxxxxxxxxxxxx> > --- > trace2/tr2_tls.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/trace2/tr2_tls.h b/trace2/tr2_tls.h > index b1e327a928e..a90bd639d48 100644 > --- a/trace2/tr2_tls.h > +++ b/trace2/tr2_tls.h > @@ -11,8 +11,8 @@ > struct tr2tls_thread_ctx { > struct strbuf thread_name; > uint64_t *array_us_start; > - int alloc; > - int nr_open_regions; /* plays role of "nr" in ALLOC_GROW */ > + size_t alloc; > + size_t nr_open_regions; /* plays role of "nr" in ALLOC_GROW */ > int thread_id; > };
