This addresses the NEEDSWORK comment in builtin/receive-pack.c: /** * NEEDSWORK: reuse find_commit_header() from jk/commit-author-parsing * after dropping "_commit" from its name and possibly moving it out * of commit.c **/ There is some duplicated logic between find_header and find_commit_header that can be consolidated instead of having two places in the code that do essentially the same thing. For the sake of simpler and more DRY code, use find_commit_header and rename it to find_header since it is not limited to finding headers for only commits. This is my first attempt to address a NEEDSWORK issue, and I'm relatively new to C so any feedback would be appreciated! John Cai (2): receive-pack.c: consolidate find header logic commit.c: rename find_commit_header to find_header builtin/am.c | 2 +- builtin/commit.c | 2 +- builtin/receive-pack.c | 48 ++++++++++++++++--------------------- commit.c | 7 +++--- commit.h | 2 +- gpg-interface.c | 2 +- pretty.c | 2 +- sequencer.c | 2 +- t/helper/test-fast-rebase.c | 2 +- 9 files changed, 32 insertions(+), 37 deletions(-) base-commit: 2ae0a9cb8298185a94e5998086f380a355dd8907 Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1125%2Fjohn-cai%2Fjc%2Freplace-find-header-v1 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1125/john-cai/jc/replace-find-header-v1 Pull-Request: https://github.com/git/git/pull/1125 -- gitgitgadget
