Re: [PATCH v3] fast-export: fix surprising behavior with --first-parent

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 21/12/2021 21.50, Junio C Hamano wrote:
Elijah Newren <newren@xxxxxxxxx> writes:

      * Changed commit message to include the detailed description of the
        problem area as suggested by Elijah. I went back and forth with my
        self about whether the message needs some "lead in", but it ended up
        getting long without adding much.

If it feels weird quoting someone else so extensively and just using
their words for the commit message, we've used a "Commit-message-by:"
trailer in the past; that could be useful here.

I do not mind tweaking the copy I already have with "Helped-by"
myself, while ...

This version looks good to me:

Reviewed-by: Elijah Newren <newren@xxxxxxxxx>

... adding this one before merging the result to 'next'.

Thanks, both.

Either way works for me. I'm not too familiar with conventions around trailers. Both seem very reasonable to me.

Thanks a bunch for the help. :)



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux