Re: [PATCH v2 0/2] Two small 'git repack' fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 20 2021, Derrick Stolee via GitGitGadget wrote:

> I was experimenting with some ideas in 'git repack' and discovered these two
> bugs.

This iteration looks good to me.

>      + ## Documentation/git-repack.txt ##
>      +@@ Documentation/git-repack.txt: to the new separate pack will be written.
>      + 	linkgit:git-pack-objects[1].
>      + 
>      + -q::
>      +-	Pass the `-q` option to 'git pack-objects'. See
>      +-	linkgit:git-pack-objects[1].
>      ++--quiet::
>      ++	Show no progress over the standard error stream and pass the `-q`
>      ++	option to 'git pack-objects'. See linkgit:git-pack-objects[1].
>      + 
>      + -n::
>      + 	Do not update the server information with
>      +

Nit: I think the addition of --quiet here is good, but also wouldn't
mind a prep change to add it as a separate step.

FWIW it appears to have been an unintended/hidden effect of a1bbc6c0176
(repack: rewrite the shell script in C, 2013-09-15), i.e. we started
using OPT__QUIET() which added "--quiet", but the shellscript just
supported -q.

Here we update the docs, but the SYNOPSIS stillj just lists -q.

I think all of that's fine & this v2 is good enough. Just braindumping
notes/observations while reading along/checking the v1->v2 diff.



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux