On 12/20/2021 8:49 AM, Jeff King wrote: > On Mon, Dec 20, 2021 at 08:37:52AM -0500, Derrick Stolee wrote: > >>> +test_expect_success TTY '--quiet disables progress' ' >>> + test_terminal env GIT_PROGRESS_DELAY=0 \ >>> + git -C midx repack -ad --quiet --write-midx 2>stderr && >>> + test_must_be_empty stderr >>> +' >>> + >>> test_done >> >> Thanks. I added this test. >> >> When first running the test, it failed because I didn't have the >> IO::Pty Perl module installed. I'm not sure why I don't fail with >> other tests that use test_terminal. If someone knows more about >> what is going on, then maybe we need to expand the TTY prereq? > > Weird. I uninstalled IO::Pty, and get: > > checking prerequisite: TTY > > [...prereq code...] > > > + perl /home/peff/compile/git/t/test-terminal.perl sh -c test -t 1 && test -t 2 > + command /usr/bin/perl /home/peff/compile/git/t/test-terminal.perl sh -c test -t 1 && test -t 2 > Can't locate IO/Pty.pm in @INC (you may need to install the IO::Pty module) (@INC contains: [...etc...] > BEGIN failed--compilation aborted at /home/peff/compile/git/t/test-terminal.perl line 5. > prerequisite TTY not satisfied > ok 25 # skip --quiet disables progress (missing TTY) > > What does running with "-x -i" say for the prereq? Ok, I got this same error and misread it as an error. The prereq is working just fine. Thanks for checking. -Stolee
