A series that used to be about adding a "global progress" state, but started with some cleanups & adding the ability to test that mode. See [1] for the v6 and [2] for a discussion on the previous 8/8 patch. This v7 ejects that 8/8 patch. I think it's safe to merge down, but per [3] etc. this topic has been stalled for a while in "needs review". I think it's had enough thorough review. The sticking point has been me & SZEDER disagreeing on whether adding that BUG() in the previous 8/8 can be deemed safe or not. So let's bypass that for now and hopefully queue these up. Once this lands we can re-visit that 8/8 and various other progress.c API & UX improvements I have unsubmitted, which have been blocked by this topic. 1. https://lore.kernel.org/git/cover-v6-0.8-00000000000-20211102T122507Z-avarab@xxxxxxxxx/ 2. https://lore.kernel.org/git/211203.868rx2t0hv.gmgdl@xxxxxxxxxxxxxxxxxxx/ 3. https://lore.kernel.org/git/211115.86wnl9qkfz.gmgdl@xxxxxxxxxxxxxxxxxxx/ Ævar Arnfjörð Bjarmason (7): leak tests: fix a memory leaks in "test-progress" helper progress.c test helper: add missing braces progress.c tests: make start/stop commands on stdin progress.c tests: test some invalid usage progress.c: add temporary variable from progress struct pack-bitmap-write.c: don't return without stop_progress() various *.c: use isatty(0|2), not isatty(STDIN_FILENO|STDERR_FILENO) builtin/bisect--helper.c | 2 +- builtin/bundle.c | 2 +- compat/mingw.c | 2 +- pack-bitmap-write.c | 6 +-- progress.c | 5 +- t/helper/test-progress.c | 52 +++++++++++++++----- t/t0500-progress-display.sh | 94 ++++++++++++++++++++++++++++--------- 7 files changed, 121 insertions(+), 42 deletions(-) Range-diff against v6: 1: 88d89652831 = 1: 5367293ee84 leak tests: fix a memory leaks in "test-progress" helper 2: 2fa92e7db83 = 2: 81788101763 progress.c test helper: add missing braces 3: 400b491449e = 3: d685c248686 progress.c tests: make start/stop commands on stdin 4: 7557975a122 = 4: 40e446da277 progress.c tests: test some invalid usage 5: 61c8da31aeb = 5: c2303bfd130 progress.c: add temporary variable from progress struct 6: f6a76b80e91 = 6: 776362de897 pack-bitmap-write.c: don't return without stop_progress() 7: 1a2eadf28d0 ! 7: 0670d1aa5f2 various *.c: use isatty(0|2), not isatty(STDIN_FILENO|STDERR_FILENO) @@ Commit message {STDIN_FILENO,STD{OUT,ERR}_FILENO} macros in "stdlib.h" to refer to them. - Let's change these for consistency, and because a subsequent commit's - commit message outlines a recipe to change all of these for ad-hoc - testing, not needing to match these with that ad-hoc regex will make - things easier to explain. + Let's change these for consistency, and because another commit that + would like to be based on top of this one[1] has a recipe to change + all of these for ad-hoc testing, not needing to match these with that + ad-hoc regex will make things easier to explain. Only one of these is + related to the "struct progress" code which it discusses, but let's + change all of these while we're at it. + + 1. https://lore.kernel.org/git/patch-v6-8.8-bff919994b5-20211102T122507Z-avarab@xxxxxxxxx/ Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> 8: bff919994b5 < -: ----------- progress.c: add & assert a "global_progress" variable -- 2.34.1.1119.g7a3fc8778ee
