On Thu, Dec 16, 2021 at 6:18 AM Johannes Altmanninger <aclopte@xxxxxxxxx> wrote:
> On Wed, Dec 15, 2021 at 02:32:36PM -0800, Junio C Hamano wrote:
> > you'll notice that existing message given to git_prompt look like
> > these:
> >
> > yesno = git_prompt(_("Are you sure [Y/n]? "), PROMPT_ECHO);
> >
> > yesno = git_prompt(_("Do you want me to do it for you "
> > "[Y/n]? "), PROMPT_ECHO);
> >
> > strbuf_addf(&msg, _("Run '%s' instead? (y/N)"), assumed);
> > answer = git_prompt(msg.buf, PROMPT_ECHO);
> >
> > - It does not leave a SP before where the end-user input goes;
> > - It append (y/N) _after_ question mark;
>
> I actually prefer this one;
>
> Run 'status' instead? [y/N]
>
> sounds better than
>
> Run 'status' instead [y/N]?
>
> but that's not a strong opinion.
For what it's worth, I also find "Run 'status' instead? [y/N]" more
sensible, and (at least based upon memory) it also seems to be the
typical way it's done in other software (including software I've
written). That said, it's a very minor point which needn't hold up the
patch if kashav isn't interested in redoing this as a single patch
which normalizes all callers to use a common format.
