Glen Choo <chooglen@xxxxxxxxxx> writes: > Jonathan Tan <jonathantanmy@xxxxxxxxxx> writes: > > > Glen Choo <chooglen@xxxxxxxxxx> writes: > >> This version is functionally identical to v2. I've only addressed > >> feedback around code organization, i.e. the the merge conflict with > >> js/branch-track-inherit and making patch 1 easier to review. Thus, some > >> discussions on [1] are still unaddressed. > > > > I do notice that some of my comments on "add --recurse-submodules option > > for branch creation" are still unaddressed so I'll hold off review until > > they are. > > Are you referring to your comments on v1 [1]? If so, I believe I had > addressed them all in v2 (and v3 is mostly a reorganization of v2). > > Let me know what you think is unaddressed :) > > [1] https://lore.kernel.org/git/20211124013153.3619998-1-jonathantanmy@xxxxxxxxxx Ah...I just saw that you are creating branches through a remote helper [1] and are still using tree_entry() non-recursively [2] (to be specific, I think we need a test where the submodule is at $ROOT/foo/bar, not just $ROOT/foo), and saw your cover letter that said that some comments were unaddressed, and jumped to a conclusion. Looking back, I think that these are my only unaddressed comments. [1] I said "If you want to use setup_tracking() through submodule--helper, I think that needs an explanation as to why a Git command wouldn't work." in https://lore.kernel.org/git/20211129210140.937875-1-jonathantanmy@xxxxxxxxxx/ [2] Discussed in https://lore.kernel.org/git/20211123021223.3472472-1-jonathantanmy@xxxxxxxxxx/
