RE: [PATCH 4/6] git-p4: Decode byte strings before printing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Is the use of strings with {} placeholders and their .format() method integral
> part of "decoding byte strings before printing", or it is just a
> new/better/improved/subjectively-preferred/whatever style?
> 
> If the latter, such a change should be separated into its own step, or at least
> needs to be mentioned and justified in the proposed log message.

As I mentioned in my other message, I would like to invest some time into tidying and modernising the script - as well as fixing bugs and improving behaviour. If I submit patches that only make subjective style improvements, are these likely to be accepted?

> Lack of explanation on "why" is shared among all these patches, it seems, so I
> won't repeat, but the patches need to explain why to their readers.

Fair enough. I will resubmit.





[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux