Joel Holdsworth <jholdsworth@xxxxxxxxxx> writes: > Subject: Re: [PATCH 1/6] git-p4: Always pass cmd arguments to subprocess as a python lists Style: downcase "Always" or anything that comes after the initial "area" designator, i.e. "git-p4:". The most important bit is missing from the proposed log message. It says what the updated code does clearly (i.e. if we find a code that still passes cmd arguments to subprocess not as a list, the title tells us that this patch did not do a thorough job at it), which is good. But it does not explain why we want to do so. There must be some backstory about wanting to do so (e.g. "because it is more Python3 way of doing things") that we can explain to the future readers of "git log" output. Being aware of the general direction these patches are taking us early would help the readers.
