Glen Choo <chooglen@xxxxxxxxxx> writes: > Minor nit: it looks like we don't need to restore inc->fn conditionally, > so instead of: > > if (inc->opts->unconditional_remote_url) > inc->fn = old_fn; > > we could just have: > > inc->fn = old_fn; > > which (purely as a matter of personal taste) looks a bit more consistent > with the unconditional assignment of: > > config_fn_t old_fn = inc->fn; > > > > No comments on the rest of the patch; it looks clean and > easy-to-understand :) Thanks for taking a look. This is a good suggestion - I'll use it.
