On 05.12.2021 20:23, SZEDER Gábor wrote:
On Tue, Nov 30, 2021 at 03:11:11PM +0100, Fabian Stelzer wrote:+ +test_expect_success GPGSSH,GPGSSH_VERIFYTIME 'message for merging local tag signed by expired ssh key' ' + test_config gpg.ssh.allowedSignersFile "${GPGSSH_ALLOWED_SIGNERS}" && + git checkout main && + git fetch . expired-signed && + git fmt-merge-msg <.git/FETCH_HEAD >actual 2>&1 && + ! grep "${GPGSSH_GOOD_SIGNATURE_TRUSTED}" actualAre these messages supposed to go to standard output or error? If it's the former, then please drop the unnecessary (and confusing) '2>&1' redirection, but if it's the latter, then save and 'grep' only stderr.
You are right, these are not correct. I copied the fmt-merge-msg calls from the GPG tests a bit above which grep for the merged tag name and for gpg signature output (i assume those two things go to stdout/err respectively). I will check and create a new patch series for fixing up all of these.
Thanks
